[1.21.3] Append unknown modded flags to removed_features level data
#1703
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: 3bb85857dddd441356f4b453557f84c54f76dc04. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1703' // https://github.com/neoforged/NeoForge/pull/1703
url 'https://prmaven.neoforged.net/NeoForge/pr1703'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
}MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1703
cd NeoForge-pr1703
curl -L https://prmaven.neoforged.net/NeoForge/pr1703/net/neoforged/neoforge/21.3.42-beta-pr-1703-pr-removed-flags/mdk-pr1703.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zipTo test a production environment, you can download the installer from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vanilla Mojang has data fixers which appends all legacy/removed feature flags to a list (
removed_features) in the level data, allowing crash reports to be aware of which flags were active and have since been removed.This PR implements a simple hook to append unknown modded flags to this list, allowing modders to know if a crash happened in an environment where their alpha testing was once enabled.
An example crash report can be found here, take note of the
Removed feature flags:entry, which lists all our test flags.